fix(parser): Switch literal impl's from one_of to literal
#464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, this was going to be done for performance reasons but when comparing this to the previous commit, `tag(char)` / `char` slowed down dramatically in the `next_slice` benchmark. However, `json` benchmark was unchanged. This also (slightly) simplifies traces, is more direct in what it says, and does still speed things up for UTF-8-exclusive `char`s, so going forward with it. Fixes winnow-rs#418 BREAKING CHANGE: `char` parers now always return `char` as the output and now require `I: Compare<char>`
Based on how `char` went, I figured we will likely see similar. Fixes winnow-rs#427 BREAKING CHANGE: `u8` parers now require `I: Compare<u8>`
epage
force-pushed
the
tagged
branch
2 times, most recently
from
040aede
to
49678ec
Compare
Pull Request Test Coverage Report for Build 7818956700
💛 - Coveralls |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
- Coverage 42.60% 42.57% -0.04%
==========================================
Files 18 18
Lines 3089 3089
==========================================
- Hits 1316 1315 -1
- Misses 1773 1774 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, this was going to be done for performance reasons but when
comparing this to the previous commit,
tag(char)/charslowed downdramatically in the
next_slicebenchmark.However,
jsonbenchmark was unchanged. This also (slightly)simplifies traces, is more direct in what it says, and does still speed
things up for UTF-8-exclusive
chars, so going forward with it.Fixes #418
Fixes #427
BREAKING CHANGE:
charparers now always returncharas the outputand now require
I: Compare<char>BREAKING CHANGE:
u8parers now requireI: Compare<u8>